Skip to content

CLI - rename run to test#1348

Merged
dOrgJelli merged 8 commits into
origin-0.10-devfrom
pileks/chore/cli-rename-run-to-test
Oct 26, 2022
Merged

CLI - rename run to test#1348
dOrgJelli merged 8 commits into
origin-0.10-devfrom
pileks/chore/cli-rename-run-to-test

Conversation

@pileks
Copy link
Copy Markdown
Contributor

@pileks pileks commented Oct 19, 2022

This PR renames the run CLI command to test.

In addition, there are some changes to the language around the test command to make it more uniform with the new name.

Niraj-Kamdar
Niraj-Kamdar previously approved these changes Oct 19, 2022
Copy link
Copy Markdown
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tackling this!

@Niraj-Kamdar
Copy link
Copy Markdown
Contributor

Can you also rename file names from run.ts and run.spec.ts to test one

Comment thread packages/cli/src/__tests__/e2e/help.spec.ts Outdated
Comment thread packages/cli/lang/en.json Outdated
@pileks pileks requested a review from Niraj-Kamdar October 20, 2022 11:59
Niraj-Kamdar
Niraj-Kamdar previously approved these changes Oct 20, 2022
@pileks pileks changed the base branch from origin-dev to origin-0.10-dev October 20, 2022 20:25
@pileks pileks dismissed Niraj-Kamdar’s stale review October 20, 2022 20:25

The base branch was changed.

@Niraj-Kamdar Niraj-Kamdar requested a review from cbrzn October 25, 2022 15:48
@dOrgJelli dOrgJelli merged commit 46446f0 into origin-0.10-dev Oct 26, 2022
@dOrgJelli dOrgJelli deleted the pileks/chore/cli-rename-run-to-test branch April 10, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants