Updated version of CLI in dependencies folder; removed uri resolver interface and all import redirects from plugins#1520
Closed
krisbitney wants to merge 1 commit into
Closed
Conversation
… interface; removed import redirects from plugins
krisbitney
requested review from
cbrzn,
dOrgJelli,
namesty,
nerfZael and
pileks
as code owners
Contributor
Author
|
Will split into separate PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI version 0.9.4 does not have the ENS text record resolver. By updating the version of the CLI we use to build packages, we are able to remove the import redirects from the plugins.
The only remaining import redirect is for the IPFS interface. The PR that replaces the ipfs and ipfs resolver plugins will remove that.
An alternative solution could be to add the ENS text record resolver to
0.9.5if we are still planning that release.Combined with #1475, this will close #1504