Remove config section from test manifest & remove legacy config types from Client#1545
Merged
Conversation
pileks
changed the base branch from
origin-dev
to
pileks/feat/remove-legacy-config-types
…-types' into pileks/feat/workflow-manifest-0.2.0
…-types' into pileks/feat/workflow-manifest-0.2.0
pileks
changed the title
config section from test manifest & remove legacy config types from Client
pileks
requested review from
Niraj-Kamdar,
cbrzn,
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
1 task
…t/workflow-manifest-0.2.0
…t/workflow-manifest-0.2.0
…t/workflow-manifest-0.2.0
…t/workflow-manifest-0.2.0
…t/workflow-manifest-0.2.0
pileks
changed the base branch from
pileks/feat/remove-legacy-config-types
to
origin-dev
pileks
dismissed stale reviews from cbrzn and krisbitney
The base branch was changed.
pileks
changed the base branch from
origin-dev
to
pileks/feat/remove-legacy-config-types
pileks
changed the base branch from
pileks/feat/remove-legacy-config-types
to
origin-dev
…kflow-manifest-0.2.0
cbrzn
previously approved these changes
Feb 23, 2023
…kflow-manifest-0.2.0
2 tasks
krisbitney
approved these changes
Feb 24, 2023
cbrzn
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets #1534, and should be merged into its branch before #1534 is merged.As per @cbrzn’s comment, merge this after #1534 is merged.
This PR aims to do two things:
configproperty from thestepsin the Test Manifest.legacyfolder from@polywrap/client-js, as it was last referenced within the Test Manifest.