Skip to content

Fix count warning php 7.2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddeboer merged 3 commits into from
Jun 3, 2019
Merged

Fix count warning php 7.2 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ff4373
Fix count warning php 7.2
SosthenG Jun 1, 2019
882102c
Add php 7.2 to travis testing matrix
SosthenG Jun 3, 2019
4440295
Add php 7.3 to travis testing matrix
SosthenG Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ php:
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3
- hhvm

matrix:
Expand Down
2 changes: 1 addition & 1 deletion src/SpreadsheetReader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public function current()

// If the spreadsheet file has column headers, use them to construct an associative
// array for the columns in this line
if (count($this->columnHeaders) === count($row)) {
if (!empty($this->columnHeaders) && count($this->columnHeaders) === count($row)) {
return array_combine(array_values($this->columnHeaders), $row);
}

Expand Down