CI: modernize GitHub Actions (PHP 8.2–8.5) - #24
Merged
Conversation
Phase 0 housekeeping: - Upgrade actions/checkout and actions/cache to v4 - Test on PHP 8.2–8.5 - Remove Scrutinizer coverage upload - Fail the suite on test errors (no continue-on-error)
…type Prophecy doubles must return string|Stringable; null triggers TypeError on modern Symfony.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s CI pipeline to run cleanly on current GitHub-hosted runners and newer PHP versions, while updating dev dependency constraints to support newer phpspec/coverage tooling.
Changes:
- Update GitHub Actions workflow to use
actions/checkout@v4andactions/cache@v4, and run a PHP 8.2–8.5 matrix. - Adjust CI execution to run
phpspecusingphpspec.yml.distwithcoverage: none, and ensure failures fail the workflow. - Broaden Composer dev constraints to allow
phpspec/phpspec^7.2 || ^8.0and coverage extension^6.1 || ^7.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/Step/ValidatorStepSpec.php | Updates specs to stub violation messages for compatibility with newer dependency behavior. |
| composer.json | Expands dev dependency version constraints for phpspec and the code coverage extension. |
| .github/workflows/checks.yml | Modernizes CI actions, updates the PHP matrix to 8.2–8.5, and tightens phpspec execution behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
14
to
+17
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php-versions: [ '7.4', '8.0', '8.1' ] | ||
| include: | ||
| - php-versions: '7.4' | ||
| coverage: pcov | ||
| composer-prefer: '--prefer-lowest --prefer-stable' | ||
| phpunit-flags: '--coverage-clover coverage.xml' | ||
| php-versions: [ '8.2', '8.3', '8.4', '8.5' ] |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 0 housekeeping for green, maintainable CI.
actions/checkoutandactions/cacheto v4 (v2 is blocked on current runners)continue-on-erroron phpspec so red means redphpspec.yml.dist(no coverage extension required in CI)phpspec/phpspec^7.2 || ^8.0so installs resolve on PHP 8.4/8.5Part of PortPHP org CI modernization (Phase 0).