Fix archive extraction to ensure it always extracts to the given path#524
Open
eregon wants to merge 1 commit into
Open
Fix archive extraction to ensure it always extracts to the given path#524eregon wants to merge 1 commit into
eregon wants to merge 1 commit into
Conversation
* Fixes postmodern#522 * The various functions.sh no longer need to hardcode $ruby_dir_name. * Remove $ruby_dir_name entirely as it is now unused.
Contributor
Author
|
@postmodern Could you review this PR? It fixes a confusing bug: #522 |
omarharby805-ship-it
approved these changes
May 7, 2026
havenwood
requested changes
May 22, 2026
| local tmp="$dest_dir/tmp" | ||
|
|
||
| mkdir -p "$dest" || return $? | ||
| rm -rf "$dest" |
Collaborator
There was a problem hiding this comment.
This should probably have a trailing || return $? in case the rm fails. (Just to match project convention, and if it carries on after this rm fails the mv below might confusingly move into $dest instead of renaming.)
| error "Multiple extracted directories under $tmp" | ||
| return 1 | ||
| fi | ||
| mv "${extracted[0]}" "$dest" |
Collaborator
There was a problem hiding this comment.
It might be a good idea to add an rm -rf "$tmp" here to clean up the now-empty $tmp dir. (If an rm is added, the mv would need a || return $?.)
| local archive="$1" | ||
| local dest="${2:-${archive%/*}}" | ||
| local dest="$2" | ||
| local dest_dir="$(dirname "$2")" |
Collaborator
There was a problem hiding this comment.
dirname "$dest" might be nice? "$2" and "$dest" are same here, so just an optional nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruby-install truffleruby-graalvm-33.0.0is broken #522