feat: Add onSuccess and onError interceptors#340
Open
Untel wants to merge 8 commits into
Open
Conversation
posva
reviewed
Sep 21, 2022
Owner
posva
left a comment
There was a problem hiding this comment.
This is interesting but it only allows one callback (including globals). I think a lengthier solution would be nice but as a plugin so it doesn't increase mande base size. I will have to take a deeper look another time
|
How about supporting |
Owner
|
Yeah, something similar could be nice. I added an empty interceptors file to src if anybody wants to give it a try |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Hi 👋
I strongly needed a way to have common interceptors (like axios) accross my app to catch generic errors, and share logic across MandeInstances .
I could overload the mande prototype or create a wrapper, but it seems ugly.
I did it really simple, only added onSuccess and onError callbacks, for response only.
I could work on something more complex like axios interceptors (multiple request + response interceptors)
if you see any interest in it.
It will also come with the need to type the newly returned type.
MandeInstance<InterceptedResponseType = { get: () => T, ... }>But i don't really know if it will be possible (axios don't allow it)