Fix all open pr comments - #39
Merged
Merged
Conversation
…files - not PAT. This is more secure.
Contributor
|
✅ ci deploy success for Environment: ci | View app |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the image build/deploy workflow automation to use a GitHub App installation token (instead of a long-lived PAT) for committing workflow-file changes to main, and improves the deploy UX by showing image tag push dates while hardening input handling.
Changes:
- Added a decision document describing the rationale and setup for using a GitHub App installation token for workflow updates.
- Updated
build-image.ymlto (a) only skip builds when both server+client images exist, (b) mint a GitHub App token for committing workflow updates, and (c) formatimage_tagoptions with push dates. - Updated deploy/list workflows to link correctly from summaries and to safely consume the date-suffixed
image_tagvalues.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/GITHUB_APP_SERVICE_TOKEN.md | New decision/setup documentation for GitHub App-based service tokens. |
| .github/workflows/list-images.yml | Uses absolute workflow links in the step summary. |
| .github/workflows/build-image.yml | Uses GitHub App token for workflow commits; refines skip logic; enhances image_tag option formatting. |
| .github/workflows/_deploy.yml | Passes image_tag via env and strips date suffix before use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+194
to
202
| TODAY=$(date -u +%F) | ||
| BASE=$(echo "$TAGGED_OBJS" | jq -c \ | ||
| --arg newtag "$NEW_TAG" \ | ||
| --arg today "$TODAY" \ | ||
| '(if map(select(.tag == $newtag)) | length == 0 | ||
| then [{ tag: $newtag, date: $today }] | ||
| else [] | ||
| end) + map(select(.tag != $newtag)) | ||
| | .[0:10]') |
Comment on lines
+143
to
+146
| # Store the App ID as a repository variable (Settings → Variables → Actions). | ||
| app-id: ${{ vars.WORKFLOW_APP_ID }} | ||
| # Store the private key PEM as a repository secret (Settings → Secrets → Actions). | ||
| private-key: ${{ secrets.WORKFLOW_APP_PRIVATE_KEY }} |
|
|
||
| ### 1 — Create the GitHub App at org level | ||
|
|
||
| 1. Go to `github.com/organizations/<your-org>/settings/Developer Setting/GitHub Apps` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.