Integrating powsybl-dependencies 2025.3.0 and powsybl-optimizer 0.16.0#1134
Merged
HugoKulesza merged 14 commits intomainfrom Jan 5, 2026
Merged
Integrating powsybl-dependencies 2025.3.0 and powsybl-optimizer 0.16.0#1134HugoKulesza merged 14 commits intomainfrom
HugoKulesza merged 14 commits intomainfrom
Conversation
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
…g report node (check in python to do) Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
…agram release Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
HugoKulesza
changed the title
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
geofjamg
reviewed
Dec 18, 2025
| self.dc_use_transformer_ratio = dc_use_transformer_ratio | ||
| if countries_to_balance is not None: | ||
| self.countries_to_balance = countries_to_balance | ||
| if component_mode is not None: |
Member
There was a problem hiding this comment.
Maybe an exception if we set both of them ?
| return self._convert_to_connected_component_mode() | ||
|
|
||
| @connected_component_mode.setter | ||
| def connected_component_mode(self, connected_component_mode: ConnectedComponentMode) -> None: |
Member
There was a problem hiding this comment.
ConnectedComponentMode class should also be flagged deprecated ?
Collaborator
Author
There was a problem hiding this comment.
I have not found a good way to do it (the class is declared in the bindings in cpp not in python)...
tests/test_voltage_initializer.py
Outdated
|
|
||
|
|
||
| @pytest.mark.skip(reason="CI doesn't have a Ampl and Knitro runtime.") | ||
| #@pytest.mark.skip(reason="CI doesn't have a Ampl and Knitro runtime.") |
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
|
|
flo-dup
approved these changes
Dec 18, 2025
Contributor
flo-dup
left a comment
flo-dup
left a comment
There was a problem hiding this comment.
Looks good to me for the diagrams part
geofjamg
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: