Add OTP function#97
Add OTP function#97PythonCoderAS wants to merge 4 commits intopraw-dev:masterfrom PythonCoderAS:otp-func
Conversation
jarhill0
left a comment
There was a problem hiding this comment.
This is surprisingly simple to implement. Can you also add tests and update the changelog?
Also, I'd like to hear @bboe's thoughts on this interface. I laid out the reasons why I like it in my comment.
Co-authored-by: Joey RH <jarhill0@users.noreply.github.com>
I can't currently test it because I don't have access to my 2FA authenticator device. |
bboe
left a comment
There was a problem hiding this comment.
I too am really surprised at how easy adding this support turned out to be. That's awesome. I just have one comment on naming, otherwise, this is awesome!
|
I think that this needs a corresponding change in PRAW to work, similar to the one in my first suggestion. Without one, when you try to authenticate, PRAW executes the following block which doesn't use the otp_function. |
I'm going to make a PR for that once this gets through first. |
|
I can write and run the tests for this, and then add the corresponding feature to PRAW. If it's possible, add me as contributor to this PR. Otherwise I can make a separate PR. |
|
You'll have to open a PR. I would cherry-pick the commits from this branch and then add your own commits after that. |
Per praw-dev/praw#1496 this will allow OTPs (2fa codes) to be supplied hourly instead of being appended to the password.