Add fast-async babel plugin by default#617
Merged
ForsakenHarmony merged 1 commit intonextfrom Aug 21, 2018
Merged
Conversation
ForsakenHarmony
approved these changes
Aug 20, 2018
lukeed
approved these changes
Aug 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Transpiles async/await to promises by default, instead of letting users encounter the weird "unexpected «" uglify error and then having them install another plugin.
Did you add tests for your changes?
Nope.
Summary
Adds the
fast-asyncbabel plugin by default. This is a really common issue/ask for folks, and the Promise-based codefast-asyncoutputs is easily clean and small enough for us to be able to promote its use by default.Does this PR introduce a breaking change?
Nope.