Fix support for default context value - #130
Merged
marvinhagemeister merged 1 commit intoDec 19, 2019
Merged
Conversation
Issue here was that the mangled "_defaultValue" prop wasn't being used.
marvinhagemeister
approved these changes
Dec 19, 2019
marvinhagemeister
left a comment
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
Awesome, that's a good catch 馃憤 Thank you so much for your PR 馃帀 馃挴
Member
|
Published as |
Contributor
Author
|
Yaaas - quick publish! ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue here was that the mangled
_defaultValueprop wasn't being used. 馃槺Pretty edge case for most libraries I suppose, which is why it might not have been caught yet
Checklist