TypeScript: General JSX types export for jsx-runtime, fixes TS4.1 compatibility#2811
Merged
Conversation
marvinhagemeister
approved these changes
Nov 2, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Sweet, thank you for the PR 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Re: microsoft/TypeScript#41330 - @weswigham's Pull Request makes sure to pick up the right types when using the new JSX transforms, looking for a general JSX namespace export. This also gets rid of the JSX namespace exports within each factory.
However, what I've seen is that TypeScript compiles to the React "convention" for
jsx-runtime, which is with a configuration like that:{ "compilerOptions": { ... "jsx": "react-jsx", "jsxImportSource": "preact", } }The imports become e.g.
I think setting the configuration to
{ "compilerOptions": { ... "jsx": "react-jsx", "jsxImportSource": "preact/compat", } }should do the trick with #2805 being merged. This would require another
jsx-dev-runtime.jsincompatto make it fully compatible with all compiler options.