support nodenext in TypeScript 4.7 #3513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
Apr 10, 2022
wight554
pushed a commit
to wight554/htm
that referenced
this pull request
Apr 25, 2022
wight554
added a commit
to wight554/htm
that referenced
this pull request
Apr 25, 2022
|
@JoviDeCroock When could I see this in a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript now supports node12's module resolution, which looks at the exports entry in package.json to resolve files.
Because preact publishes type definitions in a different folder, TS fails to resolve them.
https://devblogs.microsoft.com/typescript/announcing-typescript-4-7-beta/#package-json-exports-imports-and-self-referencing
Adding the
"types"entries in the subpath exports seem to fix it.This PR adds these entries to the subpath exports that seem to have appropriate type definitions.