Add jetpack javascript engine#3
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (5)
WalkthroughReplaces the QuickJS native integration with AndroidX JavaScriptSandbox: removes QuickJS C/C++ sources, build scripts, tests, and FFI; adds Kotlin platform API and Flutter message-channel wiring; updates Android Gradle to use androidx.javascriptengine; and introduces example app refactors and logging plus minor lint change. Changes
Sequence Diagram(s)sequenceDiagram
participant Dart as Flutter (Dart)
participant Chan as BinaryMessenger (BasicMessageChannel)
participant API as JavaScriptAndroidPlatformApi
participant Impl as JavaScriptAndroid (Kotlin)
participant SB as JavaScriptSandbox
participant ISO as JavaScriptIsolate
Dart->>Chan: startJavaScriptEngine(id)
Chan->>API: startJavaScriptEngine(id)
API->>Impl: startJavaScriptEngine(id, callback)
Impl->>SB: createConnectedInstanceAsync()
SB-->>Impl: Future completes (sandbox)
Impl->>SB: createIsolate(params)
Impl-->>API: callback(success)
Dart->>Chan: runJavaScriptReturningResult(id, code)
Chan->>API: runJavaScriptReturningResult(id, code)
API->>Impl: runJavaScriptReturningResult(id, code, callback)
Impl->>ISO: evaluateAsync(code)
ISO-->>Impl: result / exception
Impl-->>API: callback(result/error)
API-->>Chan: reply (wrapped result/error)
Chan-->>Dart: deliver response
Dart->>Chan: dispose(id)
Chan->>API: dispose(id)
API->>Impl: dispose(id, callback)
Impl->>ISO: close()
Impl-->>API: callback(success)
Estimated code review effort🎯 5 (Critical) | ⏱️ ~90 minutes Poem
Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Summary by CodeRabbit
New Features
Refactor
Chores
Example