Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/jiw1axj9m |
|
The pressed state is still a bit hard to see. So now the background is also a bit darker:
Also added a subtle transition when moving with the mouse away from a button. 👉 Preview |
|
Played around with the different heights and added a new size scale to make sure all the heights match. $size-0: 0;
$size-1: 16px;
$size-2: 20px;
$size-3: 24px;
$size-4: 28px;
$size-5: 32px;
$size-6: 40px;
$size-7: 48px;
$size-8: 64px;👀 Preview The current approach uses An alternative would be to add some padding back and use |
|
If someone wants to review this PR, I got carried away a bit and there are quite a lot of changes that move things around. 😇 But there should be no breaking change to dotcom. |



This PR adds a bit more ✨ polish to the refreshed components. Like..
disabledstate to.form-control.form-controlLabelandIssueLabelare now the same) Stickersheet34px👉32px) Size stickersheetAPI changes
$sizescale.avatar-[1-8]sizes..Label--largemodifier.Label--inlinemodifier. This can be used in places where adding a label shouldn't increase the height of the container element or line-height, for example inside a<p>element.$box-shadow-insetvariable. Used for the inner shadow of inputs$focus-shadow👉$box-shadow-focus/cc @primer/ds-core