Skip to content

More "component refresh" tweaks #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simurai merged 4 commits into from
Mar 11, 2020
Merged

More "component refresh" tweaks #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b94544
Use normal font-weight for .Label
simurai Mar 11, 2020
c26bacc
Use custom accent color
simurai Mar 11, 2020
8c615b6
Fix dark border on page load
simurai Mar 11, 2020
c80466c
Lint
simurai Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/labels/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
display: inline-block;
padding: 0 7px;
font-size: $font-size-small;
font-weight: $font-weight-semibold;
font-weight: $font-weight-normal;
line-height: 18px;
border: $border-width $border-style transparent;
border-radius: 2em;
Expand Down
4 changes: 2 additions & 2 deletions src/navigation/menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
&[aria-current] {
cursor: default;
// stylelint-disable-next-line primer/colors
background-color: $orange-000;
background-color: #fff2f0; // custom coral

&::before {
position: absolute;
Expand All @@ -60,7 +60,7 @@
width: 2px;
content: "";
// stylelint-disable-next-line primer/colors
background-color: $orange-500;
background-color: #f9826c; // custom coral
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/navigation/sidenav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
// Bar on the left
&::before {
// stylelint-disable-next-line primer/colors
background-color: $orange-500;
background-color: #f9826c; // custom coral
}
}

Expand Down
7 changes: 4 additions & 3 deletions src/navigation/underline-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,22 @@
background-color: transparent;
border: 0;
// stylelint-disable-next-line primer/borders
border-bottom: 2px $border-style transparent;
border-bottom: 2px $border-style rgba($border-gray-dark, 0);
transition: border-bottom-color 0.36s ease-in;

&:hover,
&:focus {
text-decoration: none;
border-bottom-color: $border-gray-dark;
transition: border-bottom-color 0.12s ease-out;
transition-timing-function: ease-out;
transition-duration: 0.12s;
}

&.selected,
&[role=tab][aria-selected=true],
&[aria-current] {
// stylelint-disable-next-line primer/borders
border-bottom-color: $orange-500;
border-bottom-color: #f9826c; // custom coral
}
}

Expand Down