Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/dmx3ybquv |
auareyou
reviewed
Mar 24, 2020
Contributor
auareyou
left a comment
There was a problem hiding this comment.
What is $border-radius-3for?
Contributor
Author
For cases that used to be rounder than the default. But those cases might not have to change and can keep using the new default of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Labels
Adds
.Label--purpleand.Label--pink2. UnderlineNav
The icon is a bit darker for selected items, see https://github.com/github/design-systems/issues/770#issuecomment-597369833.
3. Avatars
Uses
4pxrounded corners for.avatar-smalland avatar stacks.This also adds some variables and a utility class:
$border-radius-1: 4px;$border-radius-2: 6px;-> same as the default$border-radius..rounded-> uses the default$border-radiusvariable4. Social count
Makes sure the height matches the button when zooming. https://github.com/github/design-systems/issues/769#issuecomment-598424402
5. Pagination
Now also uses
#f9826cfor the border. -> https://github.com/github/design-systems/issues/770#issuecomment-6031311236. Menu
Removed background color on selected
.menuitem. -> https://github.com/github/design-systems/issues/770#issuecomment-6031311237. Button + lables
Now use
$blue-500. -> https://github.com/github/design-systems/issues/770#issuecomment-603688126