Skip to content

Component refresh tweaks 9 #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simurai merged 3 commits into from
Jun 17, 2020
Merged

Component refresh tweaks 9 #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7508821
Use semi bold for labels
simurai Jun 17, 2020
91b40ce
Make selected UnderlineNav item bold
simurai Jun 17, 2020
1345d68
Use $black-fade-15 for button border
simurai Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/labels/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
display: inline-block;
padding: 0 7px;
font-size: $font-size-small;
font-weight: $font-weight-normal;
font-weight: $font-weight-semibold;
line-height: 18px;
border: $border-width $border-style transparent;
border-radius: 2em;
Expand Down
1 change: 1 addition & 0 deletions src/navigation/underline-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
&.selected,
&[role=tab][aria-selected=true],
&[aria-current]:not([aria-current=false]) {
font-weight: $font-weight-bold;
// stylelint-disable-next-line primer/borders
border-bottom-color: #f9826c; // custom coral

Expand Down
2 changes: 1 addition & 1 deletion src/support/variables/misc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ $box-shadow-inset: inset 0 1px 0 rgba($border-color, 0.2) !default; // top inner
$box-shadow-focus: 0 0 0 3px rgba($border-blue, 0.3) !default; // blue focus ring

// Button variables
$border-color-button: rgba($black, 0.12) !default;
$border-color-button: $black-fade-15 !default;
$btn-active-shadow: inset 0 0.15em 0.3em $black-fade-15 !default; // TODO: Deprecate?

// Form variables
Expand Down