Remove .autocomplete-results inset border that is occluded by items#1152
Remove .autocomplete-results inset border that is occluded by items#1152simurai merged 2 commits intoprimer:release-15.2.0from
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/pzpgc1z73 |
|
@neildaniels thanks for noticing. 🙇 I can't really remember, but I think initially the intention was to show a border, but not for the But that regressed later when we added a white background to support using Hmm.. maybe we should just add a normal I'll commit and push straight to this branch. |
simurai
left a comment
There was a problem hiding this comment.
Ok, this looks ready to ship... 🚢 👍


Individual
. autocomplete-itemchildren of.autocomplete-resultsall have a background color, which completely covers the inset border.This becomes evident if any individual items have margin overrides, or the parent results view has additional padding added.
/cc @primer/ds-core