This repository was archived by the owner on Jul 7, 2025. It is now read-only.
docs(ActionList): add a11y guidance around inline descriptions#884
Merged
francinelucca merged 3 commits intomainfrom Nov 15, 2024
Merged
docs(ActionList): add a11y guidance around inline descriptions#884francinelucca merged 3 commits intomainfrom
francinelucca merged 3 commits intomainfrom
Conversation
13 tasks
Member
Author
|
TODO: merge when primer/react#5169 gets released |
TylerJDev
approved these changes
Nov 14, 2024
patrickhlauke
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/github/primer/issues/3472
Adds a11y guidance around when it is allowed for ActionList's inline descriptions to truncate text and how to do it via new
truncateprop introduced in primer/react#5169See deployment: https://primer-5f5bfef700-26441320.drafts.github.io/components/action-list#inline-descriptions
Screenshot