Skip to content

New Refresh Updates #731

@emplums

Description

@emplums

There's been a few updates to the component refresh - I believe all of these in the issue need to be implemented: https://github.com/github/design-systems/issues/770

  • There was a mistake in the sticker sheet. The selected style for primary and outline had an inset shadow of 1px when it should've been 2px.

  • Update UnderlineNav & SideNav states:
    image

  • Fix SelectMenu tab styles

  • disabled state for buttons with color icon

  • Change back the text in labels and topic tags from font-weight 500 to 400

  • Add label colors to the theme

  • After a conversation with @broccolini we have decided to get rid of the #fff2f0 background on the vertical nav as it feels too close to a danger indicator. I have updated the navigation components in the sticker sheet to have the new custom #f9826c including .pagination .current

image

Note: The icon for selected items also changed to $text-gray = $gray-600 = #586069.

  • Spacing between select menu header and select menu tabs was mistakingly set as 24px. I have no changed it to 16px. Thanks for pointing it out

  • I had needlessly made the blue text on outline buttons, button links, blue labels and topic tags $blue-600 when we were using $blue-500 and that one is ok contrast-wise against white, grey and light blue background. I have changed them all back to ```$blue-500

  • A bunch of button tweaks: https://github.com/github/design-systems/issues/770#issuecomment-605783773

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions