Skip to content

CI: disable visual testing#1786

Closed
siddharthkp wants to merge 4 commits intomainfrom
siddharth/disable-visual-testing
Closed

CI: disable visual testing#1786
siddharthkp wants to merge 4 commits intomainfrom
siddharth/disable-visual-testing

Conversation

@siddharthkp
Copy link
Copy Markdown
Member

@siddharthkp siddharthkp commented Jan 11, 2022 •
edited
Loading

Remove visual testing action till our limit is reset more context on slack.

To enable it again, we can revert this PR :)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 11, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8d3c033

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp temporarily deployed to visual-testing January 11, 2022 13:28 Inactive
@siddharthkp siddharthkp added react skip changeset This change does not need a changelog labels Jan 11, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 11, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 61.25 KB (0%)
dist/browser.umd.js 61.63 KB (0%)

@siddharthkp siddharthkp self-assigned this Jan 11, 2022
@siddharthkp siddharthkp marked this pull request as ready for review January 11, 2022 13:35
@siddharthkp siddharthkp requested a review from a team January 11, 2022 13:35
@siddharthkp siddharthkp changed the title Skip visual testing CI: skip visual testing Jan 11, 2022
@siddharthkp siddharthkp changed the title CI: skip visual testing CI: disable visual testing Jan 11, 2022
@rezrah
Copy link
Copy Markdown
Contributor

rezrah commented Jan 13, 2022

To make it easier to renable this without a code change in future, can we keep the workflow in repo and disable it via click-ops instead? https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow

@siddharthkp
Copy link
Copy Markdown
Member Author

siddharthkp commented Jan 14, 2022 •
edited
Loading

That's cool too! We don't need this PR :)

Note for future: Enable this action from this link - https://github.com/primer/react/actions/workflows/visual_testing.yml

@jsoref jsoref mentioned this pull request Feb 27, 2022
Closed
@joshblack joshblack deleted the siddharth/disable-visual-testing branch January 19, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti

@rezrah rezrah Awaiting requested review from rezrah

Assignees

@siddharthkp siddharthkp

Labels

react skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp @rezrah