-
Notifications
You must be signed in to change notification settings - Fork 658
Adds noTitle option to RelativeTime component
#4635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
367a7a4
Adds noTitle option to RelativeTime component
lindseywild a7cbda4
Removes iconbutton story
lindseywild 6d0df61
Merge branch 'main' into lw/remove-title-from-relative-time
lindseywild 857219e
Reverts package-lock.json changes
lindseywild b743489
Adds changeset
lindseywild 1c71e99
Merge branch 'main' into lw/remove-title-from-relative-time
lindseywild 0cb5d7e
Update packages/react/src/RelativeTime/RelativeTime.tsx
lindseywild 33f9c8d
Update clever-pots-leave.md
siddharthkp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': minor | ||
| --- | ||
|
|
||
| RelativeTime: Adds `noTitle` prop if you want to not render the `title` attribute with full date time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/react/src/RelativeTime/RelativeTime.examples.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import React from 'react' | ||
| import RelativeTime from './RelativeTime' | ||
| import Link from '../Link' | ||
| import {Tooltip} from '../TooltipV2' | ||
|
|
||
| export default { | ||
| title: 'Components/RelativeTime/Examples', | ||
| component: RelativeTime, | ||
| } | ||
|
|
||
| export const NoTitleAttribute = () => <RelativeTime date={new Date('2020-01-01T00:00:00Z')} noTitle={true} /> | ||
|
|
||
| export const LinkWithTooltip = () => ( | ||
| <Tooltip text={new Date('2020-01-01T00:00:00Z').toString()}> | ||
| <Link href="https://www.github.com"> | ||
| <RelativeTime date={new Date('2020-01-01T00:00:00Z')} noTitle={true} /> | ||
| </Link> | ||
| </Tooltip> | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! 👋
For the docs, can you also add when is it recommended to skip title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this description? Or are you talking about updating the in-progress docs PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally both places, but either is fine for now :)