Skip to content

Revert TextInputWithWrapper changes to remove sx and styled-system#6846

Merged
mperrotti merged 5 commits intomainfrom
mp/temp-TextInput-sx-revived
Sep 15, 2025
Merged

Revert TextInputWithWrapper changes to remove sx and styled-system#6846
mperrotti merged 5 commits intomainfrom
mp/temp-TextInput-sx-revived

Conversation

@mperrotti
Copy link
Copy Markdown
Contributor

@mperrotti mperrotti commented Sep 12, 2025 •
edited
Loading

Reverts component changes from #6666

Slack thread for context.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner September 12, 2025 17:28
@mperrotti mperrotti requested review from Copilot and hectahertz and removed request for Copilot September 12, 2025 17:28
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 12, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 281f1ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 12, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 12, 2025
joshblack
joshblack reviewed Sep 12, 2025
View reviewed changes
.changeset/silly-parks-give.md
Copy link
Copy Markdown
Member

@joshblack joshblack Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a changeset here since the change hasn't been released yet if that's helpful!

Copy link
Copy Markdown
Contributor Author

@mperrotti mperrotti Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need it to kick off the Canary release that's necessary for integration tests?

Copy link
Copy Markdown
Member

@joshblack joshblack Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! You should be good. I think the workflow will force a "fake" changeset so that it always publishes something if I remember right

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 12, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.75 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 89.89 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-6846 September 12, 2025 17:37 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 12, 2025
Copilot AI review requested due to automatic review settings September 12, 2025 18:03
Copilot AI reviewed Sep 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the sx prop to TextInput and related components that was removed in a previous change. The sx prop allows for custom styling using the design system's styling API.

  • Adds sx prop support back to TextInput, Textarea, and their underlying wrapper components
  • Updates type definitions to include SxProp in component interfaces
  • Adds new Storybook stories to demonstrate sx prop usage

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/internal/components/TextInputWrapper.tsx Adds SxProp to TextInputBaseWrapper type and imports
packages/react/src/Textarea/Textarea.tsx Adds sx prop support to Textarea component
packages/react/src/TextInput/TextInput.tsx Adds sx prop support to TextInput component
packages/react/src/TextInput/TextInput.dev.stories.tsx Adds Storybook stories demonstrating sx prop usage
.changeset/silly-parks-give.md Documents the change for release notes

@github-actions github-actions bot temporarily deployed to storybook-preview-6846 September 12, 2025 18:12 Inactive
@mperrotti mperrotti changed the title Add sx prop back to TextInput Revert TextInputWithWrapper changes to remove sx and styled-system Sep 15, 2025
@mperrotti mperrotti mentioned this pull request Sep 15, 2025
Merged
13 tasks
@primer-integration
Copy link
Copy Markdown

primer-integration bot commented Sep 15, 2025

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2528

@primer-integration
Copy link
Copy Markdown

primer-integration bot commented Sep 15, 2025

🟢 ci completed with status success.

@github-actions github-actions bot removed the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Sep 15, 2025
@github-actions github-actions bot added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Sep 15, 2025
@mperrotti mperrotti added this pull request to the merge queue Sep 15, 2025
@mperrotti mperrotti mentioned this pull request Sep 15, 2025
Closed
13 tasks
Merged via the queue into main with commit 37ce4aa Sep 15, 2025
46 checks passed
@mperrotti mperrotti deleted the mp/temp-TextInput-sx-revived branch September 15, 2025 21:37
@primer primer bot mentioned this pull request Sep 15, 2025
Merged
pksjce pushed a commit that referenced this pull request Sep 18, 2025
@mperrotti @pksjce
Revert TextInputWithWrapper changes to remove sx and styled-system (#…
554e4d2 
…6846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

Copilot code review Copilot Copilot left review comments

@hectahertz hectahertz hectahertz approved these changes

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mperrotti @joshblack @hectahertz