fix(ActionList): restore aria-disabled and data-truncate selectors for VRT compatibility#7313
fix(ActionList): restore aria-disabled and data-truncate selectors for VRT compatibility#7313Copilot wants to merge 2 commits intocss-inp-performance-minimalfrom
Conversation
|
…r VRT compatibility Co-authored-by: mattcosta7 <8616962+mattcosta7@users.noreply.github.com>
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
Two CSS selector changes in ActionList broke VRT tests by not matching the actual DOM structure.
Changes
Restored
aria-disabledcheck in hover state selector (line 129)&:not([data-disabled='true'], ...)back to&:not([aria-disabled], [data-disabled='true'], ...)listSemanticsis true,aria-disabledis set on the<li>element itself, not justdata-disabledRestored
:has()selector for truncate detection (line 645)&[data-truncate='true']back to&:has([data-truncate='true'])data-truncateattribute exists on child elements (<Truncate>component), not onItemDescriptionWrapChangelog
New
None
Changed
[aria-disabled]and[data-disabled='true']:has()to detect truncated childrenRemoved
None
Rollout strategy
Testing & Reviewing
All ActionList and Item unit tests pass. VRT tests should now pass with correct selector matching.
Merge checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.