Skip to content

Update box shadow to match Primer CSS Next #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emplums merged 2 commits into from
Apr 1, 2020
Merged

Update box shadow to match Primer CSS Next #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3ae6f
Update box shadow to match Primer CSS Next
colebemis Mar 27, 2020
f07eb1e
Update snapshots
colebemis Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/__tests__/BorderBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ describe('BorderBox', () => {

// the test returns the box shadow value without spaces, so had to manually provide the expected string here
it('renders box shadow', () => {
expect(render(<BorderBox boxShadow="small" />)).toHaveStyleRule('box-shadow', '0 1px 1px rgba(27,31,35,0.1)')
expect(render(<BorderBox boxShadow="small" />)).toHaveStyleRule('box-shadow', '0 1px 0 rgba(149,157,165,0.1)')
})
})
8 changes: 4 additions & 4 deletions src/__tests__/__snapshots__/BreadcrumbItem.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,15 +304,15 @@ exports[`Breadcrumb.Item renders the given "as" prop 1`] = `
"100px",
],
"shadows": Object {
"extra-large": "0 10px 50px rgba(27, 31, 35, 0.07)",
"extra-large": "0 12px 48px rgba(149, 157, 165, 0.3)",
"formControl": "inset 0px 2px 0px rgba(225, 228, 232, 0.2)",
"formControlDisabled": "inset 0px 2px 0px rgba(220, 227, 237, 0.3)",
"formControlFocus": "rgba(3, 102, 214, 0.3) 0px 0px 0px 0.2em",
"large": "0 1px 15px rgba(27, 31, 35, 0.15)",
"medium": "0 1px 5px rgba(27, 31, 35, 0.15)",
"large": "0 8px 24px rgba(149, 157, 165, 0.2)",
"medium": "0 3px 6px rgba(149, 157, 165, 0.15)",
"primaryActiveShadow": "inset 0px 1px 0px rgba(20, 70, 32, 0.2)",
"primaryShadow": "0px 1px 0px rgba(20, 70, 32, 0.1), inset 0px 2px 0px rgba(255, 255, 255, 0.03)",
"small": "0 1px 1px rgba(27, 31, 35, 0.1)",
"small": "0 1px 0 rgba(149, 157, 165, 0.1)",
},
"space": Array [
"0",
Expand Down
8 changes: 4 additions & 4 deletions src/__tests__/__snapshots__/CircleBadge.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`CircleBadge respects "as" prop 1`] = `
justify-content: center;
background-color: #fff;
border-radius: 50%;
box-shadow: 0 1px 5px rgba(27,31,35,0.15);
box-shadow: 0 3px 6px rgba(149,157,165,0.15);
width: 96px;
height: 96px;
}
Expand All @@ -42,7 +42,7 @@ exports[`CircleBadge respects the inline prop 1`] = `
justify-content: center;
background-color: #fff;
border-radius: 50%;
box-shadow: 0 1px 5px rgba(27,31,35,0.15);
box-shadow: 0 3px 6px rgba(149,157,165,0.15);
width: 96px;
height: 96px;
}
Expand All @@ -68,7 +68,7 @@ exports[`CircleBadge respects the variant prop 1`] = `
justify-content: center;
background-color: #fff;
border-radius: 50%;
box-shadow: 0 1px 5px rgba(27,31,35,0.15);
box-shadow: 0 3px 6px rgba(149,157,165,0.15);
width: 128px;
height: 128px;
}
Expand All @@ -94,7 +94,7 @@ exports[`CircleBadge uses the size prop to override the variant prop 1`] = `
justify-content: center;
background-color: #fff;
border-radius: 50%;
box-shadow: 0 1px 5px rgba(27,31,35,0.15);
box-shadow: 0 3px 6px rgba(149,157,165,0.15);
width: 20px;
height: 20px;
}
Expand Down
8 changes: 4 additions & 4 deletions src/__tests__/__snapshots__/FilterListItem.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,15 @@ exports[`FilterList.Item renders the given "as" prop 1`] = `
"100px",
],
"shadows": Object {
"extra-large": "0 10px 50px rgba(27, 31, 35, 0.07)",
"extra-large": "0 12px 48px rgba(149, 157, 165, 0.3)",
"formControl": "inset 0px 2px 0px rgba(225, 228, 232, 0.2)",
"formControlDisabled": "inset 0px 2px 0px rgba(220, 227, 237, 0.3)",
"formControlFocus": "rgba(3, 102, 214, 0.3) 0px 0px 0px 0.2em",
"large": "0 1px 15px rgba(27, 31, 35, 0.15)",
"medium": "0 1px 5px rgba(27, 31, 35, 0.15)",
"large": "0 8px 24px rgba(149, 157, 165, 0.2)",
"medium": "0 3px 6px rgba(149, 157, 165, 0.15)",
"primaryActiveShadow": "inset 0px 1px 0px rgba(20, 70, 32, 0.2)",
"primaryShadow": "0px 1px 0px rgba(20, 70, 32, 0.1), inset 0px 2px 0px rgba(255, 255, 255, 0.03)",
"small": "0 1px 1px rgba(27, 31, 35, 0.1)",
"small": "0 1px 0 rgba(149, 157, 165, 0.1)",
},
"space": Array [
"0",
Expand Down
8 changes: 4 additions & 4 deletions src/__tests__/__snapshots__/SubNavLink.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,15 +344,15 @@ exports[`SubNav.Link renders the given "as" prop 1`] = `
"100px",
],
"shadows": Object {
"extra-large": "0 10px 50px rgba(27, 31, 35, 0.07)",
"extra-large": "0 12px 48px rgba(149, 157, 165, 0.3)",
"formControl": "inset 0px 2px 0px rgba(225, 228, 232, 0.2)",
"formControlDisabled": "inset 0px 2px 0px rgba(220, 227, 237, 0.3)",
"formControlFocus": "rgba(3, 102, 214, 0.3) 0px 0px 0px 0.2em",
"large": "0 1px 15px rgba(27, 31, 35, 0.15)",
"medium": "0 1px 5px rgba(27, 31, 35, 0.15)",
"large": "0 8px 24px rgba(149, 157, 165, 0.2)",
"medium": "0 3px 6px rgba(149, 157, 165, 0.15)",
"primaryActiveShadow": "inset 0px 1px 0px rgba(20, 70, 32, 0.2)",
"primaryShadow": "0px 1px 0px rgba(20, 70, 32, 0.1), inset 0px 2px 0px rgba(255, 255, 255, 0.03)",
"small": "0 1px 1px rgba(27, 31, 35, 0.1)",
"small": "0 1px 0 rgba(149, 157, 165, 0.1)",
},
"space": Array [
"0",
Expand Down
8 changes: 4 additions & 4 deletions src/__tests__/__snapshots__/UnderlineNavLink.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,15 +321,15 @@ exports[`UnderlineNav.Link renders the given "as" prop 1`] = `
"100px",
],
"shadows": Object {
"extra-large": "0 10px 50px rgba(27, 31, 35, 0.07)",
"extra-large": "0 12px 48px rgba(149, 157, 165, 0.3)",
"formControl": "inset 0px 2px 0px rgba(225, 228, 232, 0.2)",
"formControlDisabled": "inset 0px 2px 0px rgba(220, 227, 237, 0.3)",
"formControlFocus": "rgba(3, 102, 214, 0.3) 0px 0px 0px 0.2em",
"large": "0 1px 15px rgba(27, 31, 35, 0.15)",
"medium": "0 1px 5px rgba(27, 31, 35, 0.15)",
"large": "0 8px 24px rgba(149, 157, 165, 0.2)",
"medium": "0 3px 6px rgba(149, 157, 165, 0.15)",
"primaryActiveShadow": "inset 0px 1px 0px rgba(20, 70, 32, 0.2)",
"primaryShadow": "0px 1px 0px rgba(20, 70, 32, 0.1), inset 0px 2px 0px rgba(255, 255, 255, 0.03)",
"small": "0 1px 1px rgba(27, 31, 35, 0.1)",
"small": "0 1px 0 rgba(149, 157, 165, 0.1)",
},
"space": Array [
"0",
Expand Down
8 changes: 4 additions & 4 deletions src/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,10 @@ const theme = {
lineHeights,
radii: ['0', '3px', '6px', '100px'],
shadows: {
small: '0 1px 1px rgba(27, 31, 35, 0.1)',
medium: '0 1px 5px rgba(27, 31, 35, 0.15)',
large: '0 1px 15px rgba(27, 31, 35, 0.15)',
'extra-large': '0 10px 50px rgba(27, 31, 35, 0.07)',
small: '0 1px 0 rgba(149, 157, 165, 0.1)',
medium: '0 3px 6px rgba(149, 157, 165, 0.15)',
large: '0 8px 24px rgba(149, 157, 165, 0.2)',
'extra-large': '0 12px 48px rgba(149, 157, 165, 0.3)',
formControl: 'inset 0px 2px 0px rgba(225, 228, 232, 0.2)',
formControlDisabled: 'inset 0px 2px 0px rgba(220, 227, 237, 0.3)',
formControlFocus: 'rgba(3, 102, 214, 0.3) 0px 0px 0px 0.2em',
Expand Down