perf(PageHeader): Scope :has() selectors to direct child for O(1) lookup#7330
Closed
mattcosta7 wants to merge 5 commits intomainfrom
Closed
perf(PageHeader): Scope :has() selectors to direct child for O(1) lookup#7330mattcosta7 wants to merge 5 commits intomainfrom
mattcosta7 wants to merge 5 commits intomainfrom
Conversation
All TitleArea and Navigation selectors are now scoped to direct children with > combinator. Part of #7312
🦋 Changeset detectedLatest commit: 3068430 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance optimizations for PageHeader CSS selectors to improve INP.
Changes
All 16
:has([data-component='TitleArea'])and:has([data-component='PH_Navigation'])selectors are now scoped to direct children with>combinator.Expected INP Impact
Why this matters
PageHeader has 16 separate :has() selectors for responsive sizing. Each one was scanning the entire subtree. On every interaction or resize, all 16 selectors fire. Direct child scoping reduces each from O(n) to O(1).
Part of the INP performance optimization effort. See #7312 for full context.