Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
| <Component | ||
| className={clsx(classes.UnderlineWrapper, className)} | ||
| ref={ref as ForwardedRef<HTMLDivElement>} | ||
| data-ready={ready ? 'true' : 'false'} |
There was a problem hiding this comment.
nit: can we do data-ready={ready ? '' : undefined}? I swear we have docs about this somewhere but I can't find 😅
There was a problem hiding this comment.
For sure! I just added undefined instead
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/12629 |
|
Integration test results from github/github-ui:
CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Part of https://github.com/github/primer/issues/6291
Improves CLS by adding
overflow: hiddenduring calculation of menu items.Base PR: #7463
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist