Remove setStates during render phase on SelectPanel#7498
Merged
hectahertz merged 2 commits intohectahertz/selectpanel-performancefrom Feb 9, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: f240551 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
hectahertz
force-pushed
the
hectahertz/selectpanel-performance-render-phase
branch
from
67e211e to
f240551
Compare
hectahertz
changed the title
github-actions
bot
requested a deployment
to
storybook-preview-7498
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/13041 |
hectahertz
merged commit 0c19492
into
hectahertz/selectpanel-performance
50 checks passed
hectahertz
deleted the
hectahertz/selectpanel-performance-render-phase
branch
hectahertz
added a commit
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5788
The previous code was calling setState directly during render. This is an anti-pattern that causes React to:
By converting these to useEffect with refs, the state updates now happen after the render completes, which is more efficient and follows React best practices.
Changelog
Changed
State update logic to remove these issues
Rollout strategy
Testing & Reviewing
Merge checklist