Switch to usage of variant for StateLabel and remove theme calls#752
Closed
tiaanduplessis wants to merge 1 commit intoprimer:masterfrom
tiaanduplessis:master
Closed
Switch to usage of variant for StateLabel and remove theme calls#752tiaanduplessis wants to merge 1 commit intoprimer:masterfrom tiaanduplessis:master
tiaanduplessis wants to merge 1 commit intoprimer:masterfrom
tiaanduplessis:master
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/br7gmkj61 |
colinkeany
requested review from
a team and
BinaryMuse
and removed request for
a team
emplums
reviewed
Apr 17, 2020
| pullMerged: colors.purple[5], | ||
| issueClosed: get('colors.red.6'), | ||
| pullClosed: get('colors.red.5'), | ||
| pullMerged: get('colors.purple.5'), |
There was a problem hiding this comment.
Quick note as I'm passing by! We should double check that this will respect a custom theme passed in via props. this might need to be:
issueClosed: get('colors.red.6')(props)
Contributor
There was a problem hiding this comment.
@emplums You're correct; I have a few proposed changes in a branch but haven't gotten back to this yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Closes #696
Merge checklist
index.d.ts) if necessary