-
Notifications
You must be signed in to change notification settings - Fork 659
PageLayout: Add new layout option PageLayout.Sidebar
#7521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2b1b003
Add to `PageLayout`
TylerJDev 32a5393
Add to slots
TylerJDev e06ca2c
Add to `SplitPageLayout`
TylerJDev c8fe36f
Add new props
TylerJDev 4a973e5
Fix sidebar
TylerJDev 11fc60c
Fix sidebar expanding width
TylerJDev 2cc07e4
Add onto `usePaneWidth`
TylerJDev 6113e5b
Merge branch 'main' into tylerjdev/page-layout-sidebar
TylerJDev 4f2918c
Remove some logic
TylerJDev 42b7ddc
Fix layout bug
TylerJDev 42955b6
Add extra styles
TylerJDev 29615df
Add `flex-shrink: 0`
TylerJDev 1e09366
Some cleanup, add changeset
TylerJDev f6bf9a5
Fix lint issues
TylerJDev ff06d9b
Add docs, tests
TylerJDev 78bfb92
test(vrt): update snapshots
TylerJDev 3567c48
Update packages/react/src/PageLayout/PageLayout.test.tsx
TylerJDev 27733e5
Update test
TylerJDev 64a5d93
Use `sidebar-max-width-diff` instead
TylerJDev 2a175af
Apply more feedback
TylerJDev c90b908
Adjust some tests
TylerJDev c8132db
Remove a test
TylerJDev f2d17c5
Adjust styling, change from `aside` to `div`
TylerJDev df3537e
test(vrt): update snapshots
TylerJDev c1f980b
Address some feedback
TylerJDev 4fbcfe1
test(vrt): update snapshots
TylerJDev edeacf6
Make storage key opt-in
TylerJDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': minor | ||
| --- | ||
|
|
||
| PageLayout: Add `PageLayout.Sidebar` sub-component |
Binary file added
BIN
+10.5 KB
...Layout.test.ts-snapshots/PageLayout-Resizable-Sidebar-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.6 KB
...PageLayout.test.ts-snapshots/PageLayout-Resizable-Sidebar-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.6 KB
...out.test.ts-snapshots/PageLayout-Resizable-Sidebar-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
...onents/PageLayout.test.ts-snapshots/PageLayout-Resizable-Sidebar-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
...Layout.test.ts-snapshots/PageLayout-Resizable-Sidebar-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.6 KB
...ayout.test.ts-snapshots/PageLayout-Resizable-Sidebar-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.7 KB
...ut.test.ts-snapshots/PageLayout-Resizable-Sidebar-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.6 KB
...nents/PageLayout.test.ts-snapshots/PageLayout-Resizable-Sidebar-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.6 KB
...ayout.test.ts-snapshots/PageLayout-Resizable-Sidebar-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.97 KB
...s/PageLayout.test.ts-snapshots/PageLayout-Sidebar-End-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.98 KB
...nents/PageLayout.test.ts-snapshots/PageLayout-Sidebar-End-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.97 KB
...ageLayout.test.ts-snapshots/PageLayout-Sidebar-End-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.97 KB
...s/components/PageLayout.test.ts-snapshots/PageLayout-Sidebar-End-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.97 KB
...s/PageLayout.test.ts-snapshots/PageLayout-Sidebar-End-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.02 KB
.../PageLayout.test.ts-snapshots/PageLayout-Sidebar-End-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.04 KB
...geLayout.test.ts-snapshots/PageLayout-Sidebar-End-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.02 KB
.../components/PageLayout.test.ts-snapshots/PageLayout-Sidebar-End-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.02 KB
.../PageLayout.test.ts-snapshots/PageLayout-Sidebar-End-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
...hots/PageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
...napshots/PageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.4 KB
...s/PageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
...st.ts-snapshots/PageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
...hots/PageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.4 KB
...ots/PageLayout-Sidebar-Fullscreen-Responsive-Variant-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.5 KB
.../PageLayout-Sidebar-Fullscreen-Responsive-Variant-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.4 KB
...t.ts-snapshots/PageLayout-Sidebar-Fullscreen-Responsive-Variant-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.4 KB
...ots/PageLayout-Sidebar-Fullscreen-Responsive-Variant-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.5 KB
...s-snapshots/PageLayout-Sidebar-Fullscreen-When-Narrow-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.5 KB
...st.ts-snapshots/PageLayout-Sidebar-Fullscreen-When-Narrow-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.4 KB
...napshots/PageLayout-Sidebar-Fullscreen-When-Narrow-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.5 KB
...yout.test.ts-snapshots/PageLayout-Sidebar-Fullscreen-When-Narrow-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.5 KB
...s-snapshots/PageLayout-Sidebar-Fullscreen-When-Narrow-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.4 KB
...-snapshots/PageLayout-Sidebar-Fullscreen-When-Narrow-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.5 KB
...apshots/PageLayout-Sidebar-Fullscreen-When-Narrow-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.4 KB
...out.test.ts-snapshots/PageLayout-Sidebar-Fullscreen-When-Narrow-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+10.4 KB
...-snapshots/PageLayout-Sidebar-Fullscreen-When-Narrow-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.95 KB
...PageLayout.test.ts-snapshots/PageLayout-Sidebar-Start-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+9 KB
...nts/PageLayout.test.ts-snapshots/PageLayout-Sidebar-Start-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.93 KB
...eLayout.test.ts-snapshots/PageLayout-Sidebar-Start-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.95 KB
...components/PageLayout.test.ts-snapshots/PageLayout-Sidebar-Start-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.95 KB
...PageLayout.test.ts-snapshots/PageLayout-Sidebar-Start-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.92 KB
...ageLayout.test.ts-snapshots/PageLayout-Sidebar-Start-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.98 KB
...Layout.test.ts-snapshots/PageLayout-Sidebar-Start-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.92 KB
...omponents/PageLayout.test.ts-snapshots/PageLayout-Sidebar-Start-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.92 KB
...ageLayout.test.ts-snapshots/PageLayout-Sidebar-Start-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
...t.ts-snapshots/PageLayout-Sidebar-With-Pane-Resizable-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
....test.ts-snapshots/PageLayout-Sidebar-With-Pane-Resizable-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
...s-snapshots/PageLayout-Sidebar-With-Pane-Resizable-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
...eLayout.test.ts-snapshots/PageLayout-Sidebar-With-Pane-Resizable-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
...t.ts-snapshots/PageLayout-Sidebar-With-Pane-Resizable-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
....ts-snapshots/PageLayout-Sidebar-With-Pane-Resizable-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+12 KB
...-snapshots/PageLayout-Sidebar-With-Pane-Resizable-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
...Layout.test.ts-snapshots/PageLayout-Sidebar-With-Pane-Resizable-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+11.9 KB
....ts-snapshots/PageLayout-Sidebar-With-Pane-Resizable-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.33 KB
...ageLayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.22 KB
...ts/PageLayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.27 KB
...Layout.test.ts-snapshots/PageLayout-Sticky-Sidebar-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.33 KB
...omponents/PageLayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.33 KB
...ageLayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.32 KB
...geLayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.33 KB
...ayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.32 KB
...mponents/PageLayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.32 KB
...geLayout.test.ts-snapshots/PageLayout-Sticky-Sidebar-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.93 KB
...tPageLayout.test.ts-snapshots/SplitPageLayout-Default-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.86 KB
...SplitPageLayout.test.ts-snapshots/SplitPageLayout-Default-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.87 KB
...geLayout.test.ts-snapshots/SplitPageLayout-Default-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.93 KB
...onents/SplitPageLayout.test.ts-snapshots/SplitPageLayout-Default-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.93 KB
...tPageLayout.test.ts-snapshots/SplitPageLayout-Default-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.93 KB
...PageLayout.test.ts-snapshots/SplitPageLayout-Default-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.92 KB
...eLayout.test.ts-snapshots/SplitPageLayout-Default-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.93 KB
...nents/SplitPageLayout.test.ts-snapshots/SplitPageLayout-Default-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+7.93 KB
...PageLayout.test.ts-snapshots/SplitPageLayout-Default-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.9 KB
...ayout.test.ts-snapshots/SplitPageLayout-Settings-Page-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.3 KB
...ageLayout.test.ts-snapshots/SplitPageLayout-Settings-Page-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.8 KB
...ut.test.ts-snapshots/SplitPageLayout-Settings-Page-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.8 KB
.../SplitPageLayout.test.ts-snapshots/SplitPageLayout-Settings-Page-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.8 KB
...ayout.test.ts-snapshots/SplitPageLayout-Settings-Page-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.7 KB
...yout.test.ts-snapshots/SplitPageLayout-Settings-Page-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.6 KB
...t.test.ts-snapshots/SplitPageLayout-Settings-Page-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.6 KB
...SplitPageLayout.test.ts-snapshots/SplitPageLayout-Settings-Page-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.6 KB
...yout.test.ts-snapshots/SplitPageLayout-Settings-Page-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...SplitPageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...ots/SplitPageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.5 KB
...itPageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...-snapshots/SplitPageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...SplitPageLayout-Sidebar-Fullscreen-Responsive-Variant-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...plitPageLayout-Sidebar-Fullscreen-Responsive-Variant-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.4 KB
...tPageLayout-Sidebar-Fullscreen-Responsive-Variant-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...snapshots/SplitPageLayout-Sidebar-Fullscreen-Responsive-Variant-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...plitPageLayout-Sidebar-Fullscreen-Responsive-Variant-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...pshots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...-snapshots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.5 KB
...ots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...test.ts-snapshots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...pshots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...shots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.4 KB
...ts/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...est.ts-snapshots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.6 KB
...shots/SplitPageLayout-Sidebar-Fullscreen-When-Narrow-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.4 KB
...t.ts-snapshots/SplitPageLayout-With-Resizable-Sidebar-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.3 KB
....test.ts-snapshots/SplitPageLayout-With-Resizable-Sidebar-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.1 KB
...s-snapshots/SplitPageLayout-With-Resizable-Sidebar-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.4 KB
...eLayout.test.ts-snapshots/SplitPageLayout-With-Resizable-Sidebar-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.4 KB
...t.ts-snapshots/SplitPageLayout-With-Resizable-Sidebar-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.2 KB
....ts-snapshots/SplitPageLayout-With-Resizable-Sidebar-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.1 KB
...-snapshots/SplitPageLayout-With-Resizable-Sidebar-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.2 KB
...Layout.test.ts-snapshots/SplitPageLayout-With-Resizable-Sidebar-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+25.2 KB
....ts-snapshots/SplitPageLayout-With-Resizable-Sidebar-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+36.1 KB
...shots/SplitPageLayout-With-Sidebar-And-Resizable-Pane-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+36.4 KB
...snapshots/SplitPageLayout-With-Sidebar-And-Resizable-Pane-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+35.8 KB
...ts/SplitPageLayout-With-Sidebar-And-Resizable-Pane-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+36.1 KB
...est.ts-snapshots/SplitPageLayout-With-Sidebar-And-Resizable-Pane-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+36.1 KB
...shots/SplitPageLayout-With-Sidebar-And-Resizable-Pane-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+35.9 KB
...hots/SplitPageLayout-With-Sidebar-And-Resizable-Pane-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+35.6 KB
...s/SplitPageLayout-With-Sidebar-And-Resizable-Pane-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+35.9 KB
...st.ts-snapshots/SplitPageLayout-With-Sidebar-And-Resizable-Pane-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+35.9 KB
...hots/SplitPageLayout-With-Sidebar-And-Resizable-Pane-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.2 KB
...ut.test.ts-snapshots/SplitPageLayout-With-Sidebar-End-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+24 KB
...Layout.test.ts-snapshots/SplitPageLayout-With-Sidebar-End-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.1 KB
...test.ts-snapshots/SplitPageLayout-With-Sidebar-End-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.1 KB
...litPageLayout.test.ts-snapshots/SplitPageLayout-With-Sidebar-End-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.1 KB
...ut.test.ts-snapshots/SplitPageLayout-With-Sidebar-End-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.2 KB
...t.test.ts-snapshots/SplitPageLayout-With-Sidebar-End-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+24 KB
...est.ts-snapshots/SplitPageLayout-With-Sidebar-End-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.1 KB
...itPageLayout.test.ts-snapshots/SplitPageLayout-With-Sidebar-End-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+24.1 KB
...t.test.ts-snapshots/SplitPageLayout-With-Sidebar-End-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+37.2 KB
....test.ts-snapshots/SplitPageLayout-With-Sidebar-Start-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+36.6 KB
...yout.test.ts-snapshots/SplitPageLayout-With-Sidebar-Start-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+37.2 KB
...st.ts-snapshots/SplitPageLayout-With-Sidebar-Start-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+37.1 KB
...tPageLayout.test.ts-snapshots/SplitPageLayout-With-Sidebar-Start-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+37.1 KB
....test.ts-snapshots/SplitPageLayout-With-Sidebar-Start-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+37.2 KB
...test.ts-snapshots/SplitPageLayout-With-Sidebar-Start-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+37 KB
...t.ts-snapshots/SplitPageLayout-With-Sidebar-Start-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+37.1 KB
...PageLayout.test.ts-snapshots/SplitPageLayout-With-Sidebar-Start-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+37.1 KB
...test.ts-snapshots/SplitPageLayout-With-Sidebar-Start-light-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+128 KB
...test.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-dark-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+130 KB
...out.test.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-dark-dimmed-linux.png
Oops, something went wrong.
Binary file added
BIN
+124 KB
...t.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+128 KB
...PageLayout.test.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-dark-linux.png
Oops, something went wrong.
Binary file added
BIN
+128 KB
...test.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file added
BIN
+126 KB
...est.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-light-colorblind-linux.png
Oops, something went wrong.
Binary file added
BIN
+124 KB
....ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-light-high-contrast-linux.png
Oops, something went wrong.
Binary file added
BIN
+126 KB
...ageLayout.test.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-light-linux.png
Oops, something went wrong.
Binary file added
BIN
+126 KB
...est.ts-snapshots/SplitPageLayout-With-Sticky-Sidebar-light-tritanopia-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import {test, expect} from '@playwright/test' | ||
| import {visit} from '../test-helpers/storybook' | ||
| import {themes} from '../test-helpers/themes' | ||
|
|
||
| const stories = [ | ||
| { | ||
| id: 'components-splitpagelayout--default', | ||
| title: 'Default', | ||
| }, | ||
| { | ||
| id: 'components-splitpagelayout-features--settings-page', | ||
| title: 'Settings Page', | ||
| }, | ||
| { | ||
| id: 'components-splitpagelayout-features--with-sidebar-start', | ||
| title: 'With Sidebar Start', | ||
| }, | ||
| { | ||
| id: 'components-splitpagelayout-features--with-sidebar-end', | ||
| title: 'With Sidebar End', | ||
| }, | ||
| { | ||
| id: 'components-splitpagelayout-features--with-resizable-sidebar', | ||
| title: 'With Resizable Sidebar', | ||
| }, | ||
| { | ||
| id: 'components-splitpagelayout-features--with-sidebar-and-resizable-pane', | ||
| title: 'With Sidebar And Resizable Pane', | ||
| }, | ||
| { | ||
| id: 'components-splitpagelayout-features--with-sticky-sidebar', | ||
| title: 'With Sticky Sidebar', | ||
| }, | ||
| { | ||
| id: 'components-splitpagelayout-features--sidebar-fullscreen-responsive-variant', | ||
| title: 'Sidebar Fullscreen Responsive Variant', | ||
| }, | ||
| ] as const | ||
|
|
||
| test.describe('SplitPageLayout', () => { | ||
| for (const story of stories) { | ||
| test.describe(story.title, () => { | ||
| for (const theme of themes) { | ||
| test.describe(theme, () => { | ||
| test('default @vrt', async ({page}) => { | ||
| await visit(page, { | ||
| id: story.id, | ||
| globals: { | ||
| colorScheme: theme, | ||
| }, | ||
| }) | ||
|
|
||
| // Default state | ||
| expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot( | ||
| `SplitPageLayout.${story.title}.${theme}.png`, | ||
| ) | ||
| }) | ||
| }) | ||
| } | ||
| }) | ||
| } | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.