fix Overlay: Change default overflow from hidden to auto#7571
fix Overlay: Change default overflow from hidden to auto#7571liuliu-dev merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 9a0a92e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/14184 |
siddharthkp
left a comment
There was a problem hiding this comment.
Seems intuitive to me, but..
git blame led me to this PR from 5 years ago when this was added, something worth testing if we are bringing back the visual bugs this had solved: #1248
Commenting for now, will wait for your response before approving
@siddharthkp Thanks for the heads up! I don't think this fix will bring back the bug. The key difference between what #1248 reverted and this fix is Both I tested with the ActionMenu MultipleSections story. When resizing the viewport to a smaller height, the menu list gets cut off. I recorded the difference between Screen.Recording.2026-02-20.at.2.54.42.PM.mov |
|
Valid, can we check how Overlays with controls behave? For example: ConfirmationDialog, SelectPanel with footer |
|
@siddharthkp I checked both:
MultiSelectModal.mov |
siddharthkp
left a comment
There was a problem hiding this comment.
Amazing, thanks for double checking!
Related issue https://github.com/github/accessibility-audits/issues/14861
Changelog
The
Overlaycomponent setsmax-height: 100vhwithoverflow: hiddenby default. At small viewports (e.g. 320×256px), this causes overlay content to be clipped. This change updates the defaultoverflowfromhiddentoautoBefore:
Screen.Recording.2026-02-20.at.11.39.46.AM.mov
After:
Screen.Recording.2026-02-20.at.11.40.50.AM.mov
Rollout strategy
Testing & Reviewing
Merge checklist