Skip to content

BorderBox and related (breaking) changes #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BinaryMuse merged 21 commits into from
Apr 20, 2020
Merged

BorderBox and related (breaking) changes #761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d128721
Add FLEX to Box and make Flex display:flex
BinaryMuse Apr 14, 2020
fb27355
Add Dropdown.Button to FilteredSearch example
BinaryMuse Apr 14, 2020
688e1b6
Split BorderBox default props
BinaryMuse Apr 16, 2020
3db413f
Shadow Doctocat components that use the old BorderBox styles
BinaryMuse Apr 16, 2020
80774f4
Update components for new BorderBox API
BinaryMuse Apr 16, 2020
d6dba25
Update tests for new BorderBox API
BinaryMuse Apr 16, 2020
a31d019
Update BorderBoxProps TS interface
BinaryMuse Apr 16, 2020
5b37a2a
Add usage note to BorderBox docs
BinaryMuse Apr 16, 2020
88aa3e7
Deprecate Flex.Item
BinaryMuse Apr 17, 2020
4d3d974
Use COMMON instead of space and color for Box system props
BinaryMuse Apr 17, 2020
30ff26e
Update system props tests for Box and BorderBox
BinaryMuse Apr 17, 2020
286582f
Update snapshots
BinaryMuse Apr 17, 2020
9c823f4
Update some more propTypes
BinaryMuse Apr 17, 2020
0eb814d
Remove Flex.Item :fire:
BinaryMuse Apr 17, 2020
ab8ff2f
Remove Flex.Item tests
BinaryMuse Apr 17, 2020
9983054
Clean up BorderProps
BinaryMuse Apr 20, 2020
0d4f730
Remove unused union
BinaryMuse Apr 20, 2020
f57c5f9
Use COMMON for Box propTypes
BinaryMuse Apr 20, 2020
791e828
Update border styles across package
BinaryMuse Apr 20, 2020
241b40b
Add all border colors from Primer CSS
BinaryMuse Apr 20, 2020
1e1cbc2
Update snapshots
BinaryMuse Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update components for new BorderBox API
  • Loading branch information
@BinaryMuse
BinaryMuse committed Apr 16, 2020
commit 80774f488b67a70ebce97df7ed7a090c588126c3
2 changes: 1 addition & 1 deletion docs/content/SideNav.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Add the `variant="lightweight"` prop to `SideNav` to render an alternative, more

```jsx live
<BorderBox p={3} backgroundColor='gray.0' maxWidth={360}>
<BorderBox border='none' borderBottom={1} mb={2} pb={1}>
<BorderBox borderWidth={0} borderBottomWidth={1} borderRadius={0} mb={2} pb={1}>
<Heading as="h5" fontSize={1} color="gray.7">Menu</Heading>
</BorderBox>
<SideNav variant="lightweight">
Expand Down
2 changes: 1 addition & 1 deletion src/CircleOcticon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function CircleOcticon(props) {
const {size, as} = props
const {icon, bg, as: asProp, ...rest} = props
return (
<BorderBox as={as} bg={bg} overflow="hidden" border="none" size={size} borderRadius="50%">
<BorderBox as={as} bg={bg} overflow="hidden" borderWidth={0} size={size} borderRadius="50%">
<Flex {...rest} alignItems="center" justifyContent="center">
<Octicon icon={icon} size={size} />
</Flex>
Expand Down
2 changes: 1 addition & 1 deletion src/SideNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function SideNavBase({variant, className, bordered, children, ...props}) {
const newClassName = classnames(className, `variant-${variantClassName}`)

if (!bordered) {
props = {...props, border: 'none'}
props = {...props, borderWidth: 0}
}

return (
Expand Down