Add narrow viewport VRT for AnchoredOverlay Fullscreen Variant#7642
Closed
Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
Closed
Add narrow viewport VRT for AnchoredOverlay Fullscreen Variant#7642Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
Conversation
|
2 tasks
Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on e2e tests for AnchoredOverlay
Add narrow viewport VRT for AnchoredOverlay Fullscreen Variant
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Fullscreen Variantstory is responsive — fullscreen only below 768px — so the default Playwright viewport was only capturing the regular anchored state, not the fullscreen behavior the story is meant to exercise.Changelog
Changed
AnchoredOverlayFullscreen Variant e2e test moved out of the general stories loop into a dedicated block with:'Open Fullscreen on Narrow'instead of'Button')544px, below the 768px breakpoint) that actually triggers fullscreen overlay behaviorRollout strategy
Test-only change, no shipping artifact affected.
Testing & Reviewing
The narrow viewport test sets
viewports['primer.breakpoint.xs'](544px) before visiting the story, which is below the 768px threshold wherevariant={{narrow: 'fullscreen', regular: 'anchored'}}switches to fullscreen mode. This produces two snapshot pairs per theme/feature-flag combination: one at default viewport (anchored), one at narrow (fullscreen).Merge checklist
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.