Skip to content

Add narrow viewport VRT for AnchoredOverlay Fullscreen Variant#7642

Closed
Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
copilot/sub-pr-7641
Closed

Add narrow viewport VRT for AnchoredOverlay Fullscreen Variant#7642
Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
copilot/sub-pr-7641

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

The Fullscreen Variant story is responsive — fullscreen only below 768px — so the default Playwright viewport was only capturing the regular anchored state, not the fullscreen behavior the story is meant to exercise.

Changelog

Changed

  • AnchoredOverlay Fullscreen Variant e2e test moved out of the general stories loop into a dedicated block with:
    • Correct button selector ('Open Fullscreen on Narrow' instead of 'Button')
    • Additional narrow viewport test (544px, below the 768px breakpoint) that actually triggers fullscreen overlay behavior

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Test-only change, no shipping artifact affected.

Testing & Reviewing

The narrow viewport test sets viewports['primer.breakpoint.xs'] (544px) before visiting the story, which is below the 768px threshold where variant={{narrow: 'fullscreen', regular: 'anchored'}} switches to fullscreen mode. This produces two snapshot pairs per theme/feature-flag combination: one at default viewport (anchored), one at narrow (fullscreen).

Merge checklist


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: bbf68c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on e2e tests for AnchoredOverlay Add narrow viewport VRT for AnchoredOverlay Fullscreen Variant Mar 9, 2026
@siddharthkp siddharthkp closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants