Fix AnchoredOverlay e2e test button selectors for strict-mode robustness#7643
Closed
Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
Closed
Fix AnchoredOverlay e2e test button selectors for strict-mode robustness#7643Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
Copilot wants to merge 2 commits intoanchored-overlay-e2e-testsfrom
Conversation
|
2 tasks
Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on e2e tests for AnchoredOverlay
Fix AnchoredOverlay e2e test button selectors for strict-mode robustness
Mar 9, 2026
siddharthkp
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two stories in the AnchoredOverlay VRT suite produced unreliable selectors:
Portal Inside Scrolling Elementrenders 200 buttons named "Button" (Playwright strict-mode violation on.click()), andFullscreen Variantuses anchor text "Open Fullscreen on Narrow" instead of "Button".Changelog
Changed
buttonName?: stringper-story field toAnchoredOverlay.test.ts(mirrorsActionMenu.test.tspattern)Fullscreen Variantstory entry now setsbuttonName: 'Open Fullscreen on Narrow'to match its actual anchor label.first()to avoid Playwright strict-mode violations when multiple matching elements are present (e.g. the 200-button grid inPortal Inside Scrolling Element)New
Removed
Rollout strategy
Test-only change; no package release needed.
Testing & Reviewing
Run the VRT suite against
AnchoredOverlaystories, specifically verifying:Portal Inside Scrolling Elementno longer throws a strict-mode violationFullscreen Variantcorrectly opens the overlay before screenshottingMerge checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.