Skip to content

Remove Textarea from @primer/styled-react#7684

Merged
jonrohan merged 3 commits intomainfrom
remove_styled_react/textarea
Mar 25, 2026
Merged

Remove Textarea from @primer/styled-react#7684
jonrohan merged 3 commits intomainfrom
remove_styled_react/textarea

Conversation

@jonrohan
Copy link
Copy Markdown
Member

@jonrohan jonrohan commented Mar 19, 2026

Overview

Removes the Textarea component and its related exports from the @primer/styled-react package. The component is not used anymore https://primer-query.githubapp.com/?query=package%3A%22%40primer%2Fstyled-react%22+name%3A%22Textarea%22

Changelog

New

None

Changed

None

Removed

  • Removed Textarea and TextareaProps exports from @primer/styled-react
  • Deleted packages/styled-react/src/components/Textarea.tsx
  • Removed Textarea test from primer-react.browser.test.tsx
  • Updated exports snapshot

Rollout strategy

  • Patch release

Testing & Reviewing

  • Exports snapshot updated to reflect removal
  • Browser test for Textarea sx prop support removed

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@jonrohan jonrohan requested a review from a team as a code owner March 19, 2026 19:49
@jonrohan jonrohan requested review from Copilot and hectahertz March 19, 2026 19:49
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 19, 2026

🦋 Changeset detected

Latest commit: 3cfec3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Mar 19, 2026
This change removes the Textarea component from the @primer/styled-react package.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated Textarea wrapper/export from the @primer/styled-react package, including its implementation file and related test/snapshot updates.

Changes:

  • Removed Textarea/TextareaProps exports from packages/styled-react/src/index.tsx.
  • Deleted packages/styled-react/src/components/Textarea.tsx and removed the corresponding browser test.
  • Updated the styled-react exports snapshot; updated Copilot PR-creation guidance.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/styled-react/src/index.tsx Stops exporting Textarea and TextareaProps from @primer/styled-react.
packages/styled-react/src/components/Textarea.tsx Deletes the styled-components wrapper around @primer/react’s Textarea.
packages/styled-react/src/tests/primer-react.browser.test.tsx Removes the browser test asserting Textarea supports the sx prop.
packages/styled-react/src/tests/snapshots/exports.test.ts.snap Updates export snapshot to remove Textarea.
.github/copilot-instructions.md Adds guidance requiring PR descriptions to follow the repo’s PR template.

@github-actions github-actions bot requested a deployment to storybook-preview-7684 March 19, 2026 19:54 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7684 March 19, 2026 20:03 Inactive
@jonrohan jonrohan enabled auto-merge March 19, 2026 20:14
Copy link
Copy Markdown
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal looks clean, no leftover references.

Two things:

  • Should the changeset be major (or minor) instead of patch? This deletes a public export, so anyone importing Textarea from @primer/styled-react will break on upgrade. Zero usage per primer-query, but semver-wise it's still a breaking change.
  • The .github/copilot-instructions.md change (PR template instruction) seems unrelated, might be cleaner in its own PR.

@jonrohan jonrohan disabled auto-merge March 25, 2026 14:50
@jonrohan jonrohan enabled auto-merge March 25, 2026 14:50
@jonrohan jonrohan added the integration-tests: skipped manually Changes in this PR do not require an integration test label Mar 25, 2026
@jonrohan jonrohan added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit ced0a71 Mar 25, 2026
57 checks passed
@jonrohan jonrohan deleted the remove_styled_react/textarea branch March 25, 2026 15:10
@primer primer bot mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants