Remove "Segoe UI Symbol" from font stack#769
Merged
emplums merged 1 commit intoprimer:release-19.0.0from Apr 17, 2020
Merged
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/muin82k8o |
Contributor
Author
|
cc @emplums |
emplums
approved these changes
Apr 17, 2020
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
Thanks for making a PR! 🙌 Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋 , I'm from GitHub Insights.
@lukehefson recently pointed out that
Segoe UI Symbolwas removed in primer/css#906 to support Chinese characters. Looks like that fix didn't make it's way into Primer Components. This PR adds that fix to Primer Components.Merge checklist
index.d.ts) if necessarycc @levindixon