Skip to content

fix: resolve prettier formatting violation in ButtonBase.tsx#7691

Merged
HiroAgustin merged 2 commits intocopilot/fix-inline-flex-loading-wrapperfrom
copilot/fix-github-actions-workflow-lint
Mar 23, 2026
Merged

fix: resolve prettier formatting violation in ButtonBase.tsx#7691
HiroAgustin merged 2 commits intocopilot/fix-inline-flex-loading-wrapperfrom
copilot/fix-github-actions-workflow-lint

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 23, 2026

Lint CI was failing due to a prettier formatting violation in ButtonBase.tsx. A nested ternary assigned to className was formatted across multiple lines, which prettier requires on a single line.

Changelog

New

Changed

  • Collapsed multi-line ternary in ButtonBase.tsx className prop to single line to satisfy prettier

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Formatting-only change, no functional impact.

Testing & Reviewing

CI lint job should pass after this change. No functional changes.

Merge checklist

Original prompt

Fix the failing GitHub Actions workflow lint
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 68182200650
Job URL: https://github.com/primer/react/actions/runs/23438353317/job/68182200650


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 23, 2026

⚠️ No Changeset found

Latest commit: 9abe0cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: HiroAgustin <1458873+HiroAgustin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/primer/react/sessions/a420ce5d-2763-4968-9ded-d6f126ae4447
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow lint fix: resolve prettier formatting violation in ButtonBase.tsx Mar 23, 2026
Copilot AI requested a review from HiroAgustin March 23, 2026 13:10
@HiroAgustin HiroAgustin marked this pull request as ready for review March 23, 2026 13:10
@HiroAgustin HiroAgustin requested a review from a team as a code owner March 23, 2026 13:10
@HiroAgustin HiroAgustin requested a review from siddharthkp March 23, 2026 13:11
@HiroAgustin HiroAgustin merged commit ab50f74 into copilot/fix-inline-flex-loading-wrapper Mar 23, 2026
40 of 41 checks passed
@HiroAgustin HiroAgustin deleted the copilot/fix-github-actions-workflow-lint branch March 23, 2026 13:11
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants