Add documentation about TypeScript support#785
Closed
BinaryMuse wants to merge 7 commits intomasterfrom
Closed
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/52f0w4liz |
emplums
reviewed
Apr 28, 2020
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
YAY thanks for doing this! Should we add any extra docs about how to import component props to use (e.g. import {Dropdown, DropdownProps} from '@primer/components) or is that obvious enough?
Contributor
Author
|
Closing this as it's included in #786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some notes about TypeScript to the Getting Started page. It includes information gathered primarily from @smockle in a PR from another project (thank you @smockle!)
https://primer-components-git-mkt-types-docs.primer.now.sh/components/getting-started#typescript
Closes #782