Skip to content

Update button docs#796

Merged
emplums merged 1 commit intomasterfrom
button-docs
May 5, 2020
Merged

Update button docs#796
emplums merged 1 commit intomasterfrom
button-docs

Conversation

@emplums
Copy link
Copy Markdown

@emplums emplums commented May 4, 2020 •
edited
Loading

The Button docs don't mention that they have access to LAYOUT so I fixed that ✨

Can be merged directly into master as it only updates docs

@vercel
Copy link
Copy Markdown

vercel bot commented May 4, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/7crrpbhbx
✅ Preview: https://primer-components-git-button-docs.primer.now.sh

@emplums emplums requested a review from BinaryMuse May 4, 2020 21:52
@emplums
Copy link
Copy Markdown
Author

emplums commented May 4, 2020 •
edited
Loading

Not sure why the build is failing in this PR 🤔 I kept seeing this same error a bunch last week too. This is what I was seeing when I thought the yarn.lock might have been corrupted: #777 (comment)

@vercel vercel bot temporarily deployed to Preview May 4, 2020 22:13 Inactive
@BinaryMuse
Copy link
Copy Markdown
Contributor

BinaryMuse commented May 4, 2020

Weird. It's building fine for tests, it's only the Vercel deploy having issues. I'm looking into it to see if I can find a pattern.

@BinaryMuse
Copy link
Copy Markdown
Contributor

BinaryMuse commented May 4, 2020

I clicked the Redeploy button in the Vercel UI and the next build was fine. 🤷‍♀️

BinaryMuse
BinaryMuse approved these changes May 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 although this makes me want to have automatic props documentation even more

@emplums emplums merged commit e19a23b into master May 5, 2020
@emplums emplums deleted the button-docs branch May 5, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BinaryMuse BinaryMuse BinaryMuse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emplums @BinaryMuse