Skip to content

Allow ActionMenu to auto-overflow its contents#2382

Closed
strackoverflow wants to merge 2 commits intomainfrom
action-menu-overflow
Closed

Allow ActionMenu to auto-overflow its contents#2382
strackoverflow wants to merge 2 commits intomainfrom
action-menu-overflow

Conversation

@strackoverflow
Copy link
Copy Markdown
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Closes #2380

🚧 WIP, more details to follow 🚧

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@strackoverflow strackoverflow self-assigned this Nov 15, 2023
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 15, 2023

⚠️ No Changeset found

Latest commit: 9a6e771

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Nov 15, 2023
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@strackoverflow
Copy link
Copy Markdown
Member Author

Closing in favor of #2383

@strackoverflow strackoverflow deleted the action-menu-overflow branch November 15, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActionMenu items overflow when viewport is too short

1 participant