Add missing SR announcement in Summary As Button story#3867
Merged
llastflowers merged 5 commits intomainfrom Jan 22, 2026
Merged
Add missing SR announcement in Summary As Button story#3867llastflowers merged 5 commits intomainfrom
llastflowers merged 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 1616537 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an accessibility remediation issue by adding a screen reader announcement for the Summary As Button Lookbook story. The change ensures that when the details element is toggled open, screen readers announce the descriptive text that becomes visible.
Changes:
- Added a hidden live region element that announces content to screen readers when the details element is toggled
- Implemented a toggle event handler to update the live region with the appropriate message
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
llastflowers
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
llastflowers
deleted the
llastflowers/14766/summary-as-button-sr-announcement-fix
branch
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Integration
N/A
List the issues that this change affects.
Relates to https://github.com/github/accessibility-audits/issues/14766
Risk Assessment
What approach did you choose and why?
is always present and only visibility is toggled, so SR does not announce it when it appears (after clicking the button). This adds a hidden announcer that is updated when the element opens.
Anything you want to highlight for special attention from reviewers?
N/A
Accessibility
Fix for a11y audit remediation issue
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.