Add text-wrap: balance to Blankslate heading and description#3945
Add text-wrap: balance to Blankslate heading and description#3945HiroAgustin merged 5 commits intomainfrom
text-wrap: balance to Blankslate heading and description#3945Conversation
🦋 Changeset detectedLatest commit: 7d1abff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: HiroAgustin <1458873+HiroAgustin@users.noreply.github.com>
text-wrap: balance to Blankslate heading and description
Co-authored-by: HiroAgustin <1458873+HiroAgustin@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Primer::Beta::Blankslate component styling to use text-wrap: balance for more visually balanced line wrapping in the heading and description, and tightens the component test to assert the new description markup.
Changes:
- Add
text-wrap: balanceto.blankslate-headingand introduce.blankslate-descriptionwith the same rule. - Ensure the description slot renders with a dedicated
blankslate-descriptionclass. - Update the Blankslate description test selector to target
p.blankslate-description. - Add a patch changeset for
@primer/view-components.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/components/primer/beta/blankslate.pcss |
Adds text-wrap: balance to heading and description styling via a new .blankslate-description rule. |
app/components/primer/beta/blankslate.rb |
Adds the blankslate-description class to the description slot’s rendered <p>. |
test/components/beta/blankslate_test.rb |
Updates the description assertion to target the new class on the <p>. |
.changeset/bright-chefs-swim.md |
Adds a patch changeset documenting the Blankslate wrapping change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Uh oh! @Copilot, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Add
text-wrap: balanceto Blankslate heading and description as done to the React component. primer/react#7568Screenshots
Before
After
Integration
List the issues that this change affects.
Closes # (type the GitHub issue number after #)
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.