Skip to content

Add text-wrap: balance to Blankslate heading and description#3945

Merged
HiroAgustin merged 5 commits intomainfrom
copilot/add-text-wrap-balance-css
Feb 20, 2026
Merged

Add text-wrap: balance to Blankslate heading and description#3945
HiroAgustin merged 5 commits intomainfrom
copilot/add-text-wrap-balance-css

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 19, 2026

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Add text-wrap: balance to Blankslate heading and description as done to the React component. primer/react#7568

Screenshots

Before

Screenshot 2026-02-20 at 08 24 53

After

Screenshot 2026-02-20 at 08 24 50

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 19, 2026

🦋 Changeset detected

Latest commit: 7d1abff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: HiroAgustin <1458873+HiroAgustin@users.noreply.github.com>
Copilot AI changed the title [WIP] Add text-wrap: balance to Blankslate heading and description Add text-wrap: balance to Blankslate heading and description Feb 19, 2026
Copilot AI requested a review from HiroAgustin February 19, 2026 21:12
Co-authored-by: HiroAgustin <1458873+HiroAgustin@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Primer::Beta::Blankslate component styling to use text-wrap: balance for more visually balanced line wrapping in the heading and description, and tightens the component test to assert the new description markup.

Changes:

  • Add text-wrap: balance to .blankslate-heading and introduce .blankslate-description with the same rule.
  • Ensure the description slot renders with a dedicated blankslate-description class.
  • Update the Blankslate description test selector to target p.blankslate-description.
  • Add a patch changeset for @primer/view-components.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
app/components/primer/beta/blankslate.pcss Adds text-wrap: balance to heading and description styling via a new .blankslate-description rule.
app/components/primer/beta/blankslate.rb Adds the blankslate-description class to the description slot’s rendered <p>.
test/components/beta/blankslate_test.rb Updates the description assertion to target the new class on the <p>.
.changeset/bright-chefs-swim.md Adds a patch changeset documenting the Blankslate wrapping change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

Uh oh! @Copilot, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 16
  • Images should have meaningful alternative text (alt text) at line 20

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link
Copy Markdown
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HiroAgustin HiroAgustin added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit 983cc29 Feb 20, 2026
32 checks passed
@HiroAgustin HiroAgustin deleted the copilot/add-text-wrap-balance-css branch February 20, 2026 12:50
@primer primer bot mentioned this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants