oelint.vars.overrideappend: Extend check#857
Merged
priv-kweihmann merged 3 commits intopriv-kweihmann:masterfrom Mar 17, 2026
Merged
oelint.vars.overrideappend: Extend check#857priv-kweihmann merged 3 commits intopriv-kweihmann:masterfrom
priv-kweihmann merged 3 commits intopriv-kweihmann:masterfrom
Conversation
michalsieron
force-pushed
the
extend-override-append-check
branch
2 times, most recently
from
5a3b565 to
f01a7b8
Compare
Using `A:class-target += " b"` actually appends to `A:class-target`, which will later override `A`. Most likely what was originally intended is conditional append to `A`. This commit extends oelint.vars.overrideappend rule to also check scenarios described above. Additionally I added a fixer for both old and new scenarios. Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
michalsieron
force-pushed
the
extend-override-append-check
branch
from
f01a7b8 to
24debf2
Compare
From the docs: > DEPENDS is a list of recipe names. Or, to be more precise, it is a > list of PROVIDES names, which usually match recipe names. As agreed in discussion priv-kweihmann#858, it must have been added by mistake. Removing it from the pkgspecific list and adding a test case for it. Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
It must have ended up here by mistake when grepping for <word>:${PN}.
Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
priv-kweihmann
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
A:class-target += " b"actually appends toA:class-target, which will later overrideA. Most likely what was originally intended is conditional append toA.This PR extends oelint.vars.overrideappend rule to also check scenarios described above. Additionally I added a fixer for both old and new scenarios.
This PR supersedes #856.
Pull request checklist
Bugfix
New feature
wiki-creator.pywas run and a new wiki document was filled with information