Attempts to run with the data.csv and params.yaml file from the test/satellites/ directory fails with:
ERROR: failed to parse 'stages.cgpm-infer-hyperparameters.cmd' in 'dvc.yaml': Could not find 'cgpm.iterations'
Probably the file conventions have just changed and the software appears to expect either iterations alone or iterations and minutes. In the later case it seems to use minutes and ignore iterations. So... maybe some of the parameter logic needs to change so that only one or the other can be uncommented? Otherwise uses will have to guess which takes priority (true, the priority could be documented, but it seems better to be unambiguous?).
After fixing that, the run still fails, this time with:
Traceback (most recent call last):
File "/home/ubuntu/SatellitesQL/scripts/subsample.py", line 64, in <module>
main()
File "/home/ubuntu/SatellitesQL/scripts/subsample.py", line 35, in main
subsampling_config = params["sub_sample"] or {}
KeyError: 'sub_sample'
ERROR: failed to reproduce 'subsample': failed to run: mkdir -p data/test && python scripts/subsample.py --data data/data.csv --test-data-dir data/test --params params.yaml --output data/subsampled.csv, exited with 1
Note that there is no sub_sample section in the included params.yaml so the code could be using defaults or perhaps choking because the section is missing?
Attempts to run with the
data.csvandparams.yamlfile from thetest/satellites/directory fails with:ERROR: failed to parse 'stages.cgpm-infer-hyperparameters.cmd' in 'dvc.yaml': Could not find 'cgpm.iterations'Probably the file conventions have just changed and the software appears to expect either
iterationsalone oriterationsandminutes. In the later case it seems to useminutesand ignoreiterations. So... maybe some of the parameter logic needs to change so that only one or the other can be uncommented? Otherwise uses will have to guess which takes priority (true, the priority could be documented, but it seems better to be unambiguous?).After fixing that, the run still fails, this time with:
Note that there is no
sub_samplesection in the includedparams.yamlso the code could be using defaults or perhaps choking because the section is missing?