Convert Devenv to Nix flake#197
Conversation
893c54c to
a454f6d
Compare
KingMob
left a comment
There was a problem hiding this comment.
It looks ok afaict, but I'm not a Nix or python expert.
It looks like the Github commit-lint action is broken, though. It says it can't find pnpm. (If it helps, I generally have good luck debugging GH Actions locally with the act tool.)
|
Yeah I'm having a look into that, it's weird because the step before also uses |
The devshell can now be entered either using Direnv (https://direnv.net) or by manually running `nix develop`.
a454f6d to
648edc2
Compare
…eing too far down PYTHONPATH
This reverts commit 052468e.
|
Looks good afaict. I noticed the .envrc is running |
KingMob
left a comment
There was a problem hiding this comment.
LGTM, tho see my note about watching all nix files recursively.
The Devenv dotfiles can be removed as Devenv is no longer used at all. However well pointed out as I'd forgotten to remove the old unused flake stub in the The |
Change .envrc to use Bash file globbing rather than the find sub-shell invocation.
|
@Schaechtle @srounce I just noticed, the docs weren't updated to match. |
|
The |
/var/...Supercedes #194 & #195, incorporating the fixes they provide.