fix: include descriptions for reference entries in search index - #1539
Merged
doradocodes merged 1 commit intoJul 28, 2026
Merged
Conversation
Contributor
|
@slash-init This looks good! Merging now. |
Contributor
Author
|
@doradocodes Thanks! Just a doubt, don't we have to add a regression test for this bug? I asked the same in the issue thread. |
Contributor
|
@slash-init answered your question in the original thread! Thanks for double-checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where reference entries in the generated search index were missing their
descriptionfield. While the builder verified that a description existed, it never assigned it before creating the search index entry, causing the field to be omitted from the generated JSON and preventing reference descriptions from being indexed for search.fixes #1537