Version 1.4.1 adds reserved function “size”

[da091005]

Topic

Between version 1.4.0 and 1.4.1 a reserved function “size” was added. I feel like this variable name is used way too commonly in sketches to have it as a reserved function.

[limzykenneth]

As far as I can see there is no size function exposed or defined by p5.js in the global scope and trying to assign a value to size in 1.4.1 does not result in a warning. Can you provide more info about what you have observed?

[da091005]

This might be web-editor specific then. But when I change the source from 1.4.1 to 1.4.0 the error goes away.

[limzykenneth]

Can you share a link to the sketch you are using to test this? Thanks.

[da091005]

Hello, yes it’s an incomplete sketch, but it has a class that uses “size” as one of the attributes. But, even when I change those variable names inside the class, there is still a variable “size” in the main sketch and I still get the warning. I even went to some of my old sketches and updated the source from 1.4.0. to 1.4.1 and I get the same warning on those (because I frequently use “size” as a variable name.

https://editor.p5js.org/UnOriginalPun/sketches/xYNvt_mYr

[limzykenneth]

@almchung Can you perhaps have a look at this as I think it may be related to some FES bug?

[davepagurek]

It looks like this line in the FES source is getting its list of reserved function names from the names of all the methods on all p5 classes:

p5.js/src/core/friendly_errors/sketch_reader.js

Line 305 in 194c0dc

functionArray.push(...Object.keys(p5Constructors[keyArray[i]].prototype));

I wonder if it's marking size as reserved because it exists on p5.TypedDict.prototype?

p5.js/src/data/p5.TypedDict.js

Line 118 in 374acfb

p5.TypedDict.prototype.size = function() {

[mishaushev]

so what is the solution to reserved function "size"?

[davepagurek]

For now, you can ignore it, it's FES misreporting it as a reserved word when it isn't really.

If someone wants to make a PR to fix this, I believe they would need to update this line to only include some p5 constructors instead of all of them:

p5.js/src/core/friendly_errors/sketch_reader.js

Line 305 in 194c0dc

functionArray.push(...Object.keys(p5Constructors[keyArray[i]].prototype));

I think maybe just p5, p5.Renderer, p5.RendererGL, and p5.Renderer2D? Am I missing anything else that contributes global methods?

[mishaushev]

For now, you can ignore it, it's FES misreporting it as a reserved word when it isn't really.

If someone wants to make a PR to fix this, I believe they would need to update this line to only include some p5 constructors instead of all of them:

p5.js/src/core/friendly_errors/sketch_reader.js

Line 305 in 194c0dc

functionArray.push(...Object.keys(p5Constructors[keyArray[i]].prototype));

I think maybe just p5, p5.Renderer, p5.RendererGL, and p5.Renderer2D? Am I missing anything else that contributes global methods?

But what to do if the code doesn't run cause of the issue? How can I ignore it?

[davepagurek]

Does it go away if you use p5.disableFriendlyErrors = true? https://p5js.org/reference/#/p5/disableFriendlyErrors