Skip to content

createFilterShader docs + fixes - #6530

Closed
davepagurek wants to merge 1 commit into
processing:mainfrom
davepagurek:fix/createFilterShader
Closed

createFilterShader docs + fixes#6530
davepagurek wants to merge 1 commit into
processing:mainfrom
davepagurek:fix/createFilterShader

Conversation

@davepagurek

Copy link
Copy Markdown
Contributor

Resolves #6520

Changes

  • Removes errors for filter shaders made in 2D mode
  • Adds handling of filter shaders in 2D mode (previously it just handled built-ins)
  • Clarifies createFilterShader docs for uniforms
  • Adds an example to shader.copyToContext

Screenshots of the change

Simple example: https://editor.p5js.org/davepagurek/sketches/P1idSsFQx

A warp filter applied to a video in 2D mode: https://editor.p5js.org/davepagurek/sketches/M407BnRZg
image

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@davepagurek davepagurek mentioned this pull request Nov 6, 2023
3 tasks
@Qianqianye Qianqianye added this to the 1.9.0 milestone Nov 23, 2023
@Qianqianye Qianqianye mentioned this pull request Nov 23, 2023
7 tasks
@davepagurek

Copy link
Copy Markdown
Contributor Author

I'm going to close this, these changes ended up part of #6559 which resolves this issue.

@davepagurek
davepagurek deleted the fix/createFilterShader branch November 23, 2023 23:26
@davepagurek
davepagurek restored the fix/createFilterShader branch December 3, 2023 15:02
@davepagurek davepagurek reopened this Dec 3, 2023
@davepagurek

Copy link
Copy Markdown
Contributor Author

Ignore the noise, I wanted to get some screenshots of merge conflicts for a tutorial 🙂 Closing this again now!

@davepagurek davepagurek closed this Dec 3, 2023
@davepagurek
davepagurek deleted the fix/createFilterShader branch December 3, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

createFilterShader throws an error in 2D mode

2 participants